OpenCores
Issue List
Or1ksim does not use consistent config parameter names #21
Closed jeremybennett opened this issue over 15 years ago
jeremybennett commented over 15 years ago

Or1ksim does not use consistent names for config parameters. This makes errors by the user more likely.

Main culprit is parameters, which are filenames. This is variously called:

  • vapi_fn (section vapi)
  • filename (sections vga, fb)
  • file/rxfile/txfile (sections ethernet, kbd)

I suggest the parameter should be "file" where this is no direction implied and "rxfile" or "txfile" where a direction is implied.

In section gpio, the parameter is called "base_vapi_id", where all other sections refer to this as "vapi_id". Although GPIO is unusual in actually using more than one VAPI ID, all sections may use more than one. For consistency, I suggest that the keyword "vapi_id" is used throughout.

In all cases, the legacy name should be permitted for backwards compatibility.

jeremybennett commented over 15 years ago

These suggestions have been adopted for OpenRISC 0.3.0rc1.

jeremybennett was assigned over 15 years ago
jeremybennett closed this over 15 years ago

Assignee
jeremybennett
Labels
Bug