| 1 |
747 |
jeremybenn |
// Copyright 2009 The Go Authors. All rights reserved.
|
| 2 |
|
|
// Use of this source code is governed by a BSD-style
|
| 3 |
|
|
// license that can be found in the LICENSE file.
|
| 4 |
|
|
|
| 5 |
|
|
// Tests for client.go
|
| 6 |
|
|
|
| 7 |
|
|
package http_test
|
| 8 |
|
|
|
| 9 |
|
|
import (
|
| 10 |
|
|
"crypto/tls"
|
| 11 |
|
|
"errors"
|
| 12 |
|
|
"fmt"
|
| 13 |
|
|
"io"
|
| 14 |
|
|
"io/ioutil"
|
| 15 |
|
|
"net"
|
| 16 |
|
|
. "net/http"
|
| 17 |
|
|
"net/http/httptest"
|
| 18 |
|
|
"net/url"
|
| 19 |
|
|
"strconv"
|
| 20 |
|
|
"strings"
|
| 21 |
|
|
"sync"
|
| 22 |
|
|
"testing"
|
| 23 |
|
|
)
|
| 24 |
|
|
|
| 25 |
|
|
var robotsTxtHandler = HandlerFunc(func(w ResponseWriter, r *Request) {
|
| 26 |
|
|
w.Header().Set("Last-Modified", "sometime")
|
| 27 |
|
|
fmt.Fprintf(w, "User-agent: go\nDisallow: /something/")
|
| 28 |
|
|
})
|
| 29 |
|
|
|
| 30 |
|
|
// pedanticReadAll works like ioutil.ReadAll but additionally
|
| 31 |
|
|
// verifies that r obeys the documented io.Reader contract.
|
| 32 |
|
|
func pedanticReadAll(r io.Reader) (b []byte, err error) {
|
| 33 |
|
|
var bufa [64]byte
|
| 34 |
|
|
buf := bufa[:]
|
| 35 |
|
|
for {
|
| 36 |
|
|
n, err := r.Read(buf)
|
| 37 |
|
|
if n == 0 && err == nil {
|
| 38 |
|
|
return nil, fmt.Errorf("Read: n=0 with err=nil")
|
| 39 |
|
|
}
|
| 40 |
|
|
b = append(b, buf[:n]...)
|
| 41 |
|
|
if err == io.EOF {
|
| 42 |
|
|
n, err := r.Read(buf)
|
| 43 |
|
|
if n != 0 || err != io.EOF {
|
| 44 |
|
|
return nil, fmt.Errorf("Read: n=%d err=%#v after EOF", n, err)
|
| 45 |
|
|
}
|
| 46 |
|
|
return b, nil
|
| 47 |
|
|
}
|
| 48 |
|
|
if err != nil {
|
| 49 |
|
|
return b, err
|
| 50 |
|
|
}
|
| 51 |
|
|
}
|
| 52 |
|
|
panic("unreachable")
|
| 53 |
|
|
}
|
| 54 |
|
|
|
| 55 |
|
|
func TestClient(t *testing.T) {
|
| 56 |
|
|
ts := httptest.NewServer(robotsTxtHandler)
|
| 57 |
|
|
defer ts.Close()
|
| 58 |
|
|
|
| 59 |
|
|
r, err := Get(ts.URL)
|
| 60 |
|
|
var b []byte
|
| 61 |
|
|
if err == nil {
|
| 62 |
|
|
b, err = pedanticReadAll(r.Body)
|
| 63 |
|
|
r.Body.Close()
|
| 64 |
|
|
}
|
| 65 |
|
|
if err != nil {
|
| 66 |
|
|
t.Error(err)
|
| 67 |
|
|
} else if s := string(b); !strings.HasPrefix(s, "User-agent:") {
|
| 68 |
|
|
t.Errorf("Incorrect page body (did not begin with User-agent): %q", s)
|
| 69 |
|
|
}
|
| 70 |
|
|
}
|
| 71 |
|
|
|
| 72 |
|
|
func TestClientHead(t *testing.T) {
|
| 73 |
|
|
ts := httptest.NewServer(robotsTxtHandler)
|
| 74 |
|
|
defer ts.Close()
|
| 75 |
|
|
|
| 76 |
|
|
r, err := Head(ts.URL)
|
| 77 |
|
|
if err != nil {
|
| 78 |
|
|
t.Fatal(err)
|
| 79 |
|
|
}
|
| 80 |
|
|
if _, ok := r.Header["Last-Modified"]; !ok {
|
| 81 |
|
|
t.Error("Last-Modified header not found.")
|
| 82 |
|
|
}
|
| 83 |
|
|
}
|
| 84 |
|
|
|
| 85 |
|
|
type recordingTransport struct {
|
| 86 |
|
|
req *Request
|
| 87 |
|
|
}
|
| 88 |
|
|
|
| 89 |
|
|
func (t *recordingTransport) RoundTrip(req *Request) (resp *Response, err error) {
|
| 90 |
|
|
t.req = req
|
| 91 |
|
|
return nil, errors.New("dummy impl")
|
| 92 |
|
|
}
|
| 93 |
|
|
|
| 94 |
|
|
func TestGetRequestFormat(t *testing.T) {
|
| 95 |
|
|
tr := &recordingTransport{}
|
| 96 |
|
|
client := &Client{Transport: tr}
|
| 97 |
|
|
url := "http://dummy.faketld/"
|
| 98 |
|
|
client.Get(url) // Note: doesn't hit network
|
| 99 |
|
|
if tr.req.Method != "GET" {
|
| 100 |
|
|
t.Errorf("expected method %q; got %q", "GET", tr.req.Method)
|
| 101 |
|
|
}
|
| 102 |
|
|
if tr.req.URL.String() != url {
|
| 103 |
|
|
t.Errorf("expected URL %q; got %q", url, tr.req.URL.String())
|
| 104 |
|
|
}
|
| 105 |
|
|
if tr.req.Header == nil {
|
| 106 |
|
|
t.Errorf("expected non-nil request Header")
|
| 107 |
|
|
}
|
| 108 |
|
|
}
|
| 109 |
|
|
|
| 110 |
|
|
func TestPostRequestFormat(t *testing.T) {
|
| 111 |
|
|
tr := &recordingTransport{}
|
| 112 |
|
|
client := &Client{Transport: tr}
|
| 113 |
|
|
|
| 114 |
|
|
url := "http://dummy.faketld/"
|
| 115 |
|
|
json := `{"key":"value"}`
|
| 116 |
|
|
b := strings.NewReader(json)
|
| 117 |
|
|
client.Post(url, "application/json", b) // Note: doesn't hit network
|
| 118 |
|
|
|
| 119 |
|
|
if tr.req.Method != "POST" {
|
| 120 |
|
|
t.Errorf("got method %q, want %q", tr.req.Method, "POST")
|
| 121 |
|
|
}
|
| 122 |
|
|
if tr.req.URL.String() != url {
|
| 123 |
|
|
t.Errorf("got URL %q, want %q", tr.req.URL.String(), url)
|
| 124 |
|
|
}
|
| 125 |
|
|
if tr.req.Header == nil {
|
| 126 |
|
|
t.Fatalf("expected non-nil request Header")
|
| 127 |
|
|
}
|
| 128 |
|
|
if tr.req.Close {
|
| 129 |
|
|
t.Error("got Close true, want false")
|
| 130 |
|
|
}
|
| 131 |
|
|
if g, e := tr.req.ContentLength, int64(len(json)); g != e {
|
| 132 |
|
|
t.Errorf("got ContentLength %d, want %d", g, e)
|
| 133 |
|
|
}
|
| 134 |
|
|
}
|
| 135 |
|
|
|
| 136 |
|
|
func TestPostFormRequestFormat(t *testing.T) {
|
| 137 |
|
|
tr := &recordingTransport{}
|
| 138 |
|
|
client := &Client{Transport: tr}
|
| 139 |
|
|
|
| 140 |
|
|
urlStr := "http://dummy.faketld/"
|
| 141 |
|
|
form := make(url.Values)
|
| 142 |
|
|
form.Set("foo", "bar")
|
| 143 |
|
|
form.Add("foo", "bar2")
|
| 144 |
|
|
form.Set("bar", "baz")
|
| 145 |
|
|
client.PostForm(urlStr, form) // Note: doesn't hit network
|
| 146 |
|
|
|
| 147 |
|
|
if tr.req.Method != "POST" {
|
| 148 |
|
|
t.Errorf("got method %q, want %q", tr.req.Method, "POST")
|
| 149 |
|
|
}
|
| 150 |
|
|
if tr.req.URL.String() != urlStr {
|
| 151 |
|
|
t.Errorf("got URL %q, want %q", tr.req.URL.String(), urlStr)
|
| 152 |
|
|
}
|
| 153 |
|
|
if tr.req.Header == nil {
|
| 154 |
|
|
t.Fatalf("expected non-nil request Header")
|
| 155 |
|
|
}
|
| 156 |
|
|
if g, e := tr.req.Header.Get("Content-Type"), "application/x-www-form-urlencoded"; g != e {
|
| 157 |
|
|
t.Errorf("got Content-Type %q, want %q", g, e)
|
| 158 |
|
|
}
|
| 159 |
|
|
if tr.req.Close {
|
| 160 |
|
|
t.Error("got Close true, want false")
|
| 161 |
|
|
}
|
| 162 |
|
|
// Depending on map iteration, body can be either of these.
|
| 163 |
|
|
expectedBody := "foo=bar&foo=bar2&bar=baz"
|
| 164 |
|
|
expectedBody1 := "bar=baz&foo=bar&foo=bar2"
|
| 165 |
|
|
if g, e := tr.req.ContentLength, int64(len(expectedBody)); g != e {
|
| 166 |
|
|
t.Errorf("got ContentLength %d, want %d", g, e)
|
| 167 |
|
|
}
|
| 168 |
|
|
bodyb, err := ioutil.ReadAll(tr.req.Body)
|
| 169 |
|
|
if err != nil {
|
| 170 |
|
|
t.Fatalf("ReadAll on req.Body: %v", err)
|
| 171 |
|
|
}
|
| 172 |
|
|
if g := string(bodyb); g != expectedBody && g != expectedBody1 {
|
| 173 |
|
|
t.Errorf("got body %q, want %q or %q", g, expectedBody, expectedBody1)
|
| 174 |
|
|
}
|
| 175 |
|
|
}
|
| 176 |
|
|
|
| 177 |
|
|
func TestRedirects(t *testing.T) {
|
| 178 |
|
|
var ts *httptest.Server
|
| 179 |
|
|
ts = httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
|
| 180 |
|
|
n, _ := strconv.Atoi(r.FormValue("n"))
|
| 181 |
|
|
// Test Referer header. (7 is arbitrary position to test at)
|
| 182 |
|
|
if n == 7 {
|
| 183 |
|
|
if g, e := r.Referer(), ts.URL+"/?n=6"; e != g {
|
| 184 |
|
|
t.Errorf("on request ?n=7, expected referer of %q; got %q", e, g)
|
| 185 |
|
|
}
|
| 186 |
|
|
}
|
| 187 |
|
|
if n < 15 {
|
| 188 |
|
|
Redirect(w, r, fmt.Sprintf("/?n=%d", n+1), StatusFound)
|
| 189 |
|
|
return
|
| 190 |
|
|
}
|
| 191 |
|
|
fmt.Fprintf(w, "n=%d", n)
|
| 192 |
|
|
}))
|
| 193 |
|
|
defer ts.Close()
|
| 194 |
|
|
|
| 195 |
|
|
c := &Client{}
|
| 196 |
|
|
_, err := c.Get(ts.URL)
|
| 197 |
|
|
if e, g := "Get /?n=10: stopped after 10 redirects", fmt.Sprintf("%v", err); e != g {
|
| 198 |
|
|
t.Errorf("with default client Get, expected error %q, got %q", e, g)
|
| 199 |
|
|
}
|
| 200 |
|
|
|
| 201 |
|
|
// HEAD request should also have the ability to follow redirects.
|
| 202 |
|
|
_, err = c.Head(ts.URL)
|
| 203 |
|
|
if e, g := "Head /?n=10: stopped after 10 redirects", fmt.Sprintf("%v", err); e != g {
|
| 204 |
|
|
t.Errorf("with default client Head, expected error %q, got %q", e, g)
|
| 205 |
|
|
}
|
| 206 |
|
|
|
| 207 |
|
|
// Do should also follow redirects.
|
| 208 |
|
|
greq, _ := NewRequest("GET", ts.URL, nil)
|
| 209 |
|
|
_, err = c.Do(greq)
|
| 210 |
|
|
if e, g := "Get /?n=10: stopped after 10 redirects", fmt.Sprintf("%v", err); e != g {
|
| 211 |
|
|
t.Errorf("with default client Do, expected error %q, got %q", e, g)
|
| 212 |
|
|
}
|
| 213 |
|
|
|
| 214 |
|
|
var checkErr error
|
| 215 |
|
|
var lastVia []*Request
|
| 216 |
|
|
c = &Client{CheckRedirect: func(_ *Request, via []*Request) error {
|
| 217 |
|
|
lastVia = via
|
| 218 |
|
|
return checkErr
|
| 219 |
|
|
}}
|
| 220 |
|
|
res, err := c.Get(ts.URL)
|
| 221 |
|
|
finalUrl := res.Request.URL.String()
|
| 222 |
|
|
if e, g := "", fmt.Sprintf("%v", err); e != g {
|
| 223 |
|
|
t.Errorf("with custom client, expected error %q, got %q", e, g)
|
| 224 |
|
|
}
|
| 225 |
|
|
if !strings.HasSuffix(finalUrl, "/?n=15") {
|
| 226 |
|
|
t.Errorf("expected final url to end in /?n=15; got url %q", finalUrl)
|
| 227 |
|
|
}
|
| 228 |
|
|
if e, g := 15, len(lastVia); e != g {
|
| 229 |
|
|
t.Errorf("expected lastVia to have contained %d elements; got %d", e, g)
|
| 230 |
|
|
}
|
| 231 |
|
|
|
| 232 |
|
|
checkErr = errors.New("no redirects allowed")
|
| 233 |
|
|
res, err = c.Get(ts.URL)
|
| 234 |
|
|
finalUrl = res.Request.URL.String()
|
| 235 |
|
|
if e, g := "Get /?n=1: no redirects allowed", fmt.Sprintf("%v", err); e != g {
|
| 236 |
|
|
t.Errorf("with redirects forbidden, expected error %q, got %q", e, g)
|
| 237 |
|
|
}
|
| 238 |
|
|
}
|
| 239 |
|
|
|
| 240 |
|
|
var expectedCookies = []*Cookie{
|
| 241 |
|
|
&Cookie{Name: "ChocolateChip", Value: "tasty"},
|
| 242 |
|
|
&Cookie{Name: "First", Value: "Hit"},
|
| 243 |
|
|
&Cookie{Name: "Second", Value: "Hit"},
|
| 244 |
|
|
}
|
| 245 |
|
|
|
| 246 |
|
|
var echoCookiesRedirectHandler = HandlerFunc(func(w ResponseWriter, r *Request) {
|
| 247 |
|
|
for _, cookie := range r.Cookies() {
|
| 248 |
|
|
SetCookie(w, cookie)
|
| 249 |
|
|
}
|
| 250 |
|
|
if r.URL.Path == "/" {
|
| 251 |
|
|
SetCookie(w, expectedCookies[1])
|
| 252 |
|
|
Redirect(w, r, "/second", StatusMovedPermanently)
|
| 253 |
|
|
} else {
|
| 254 |
|
|
SetCookie(w, expectedCookies[2])
|
| 255 |
|
|
w.Write([]byte("hello"))
|
| 256 |
|
|
}
|
| 257 |
|
|
})
|
| 258 |
|
|
|
| 259 |
|
|
// Just enough correctness for our redirect tests. Uses the URL.Host as the
|
| 260 |
|
|
// scope of all cookies.
|
| 261 |
|
|
type TestJar struct {
|
| 262 |
|
|
m sync.Mutex
|
| 263 |
|
|
perURL map[string][]*Cookie
|
| 264 |
|
|
}
|
| 265 |
|
|
|
| 266 |
|
|
func (j *TestJar) SetCookies(u *url.URL, cookies []*Cookie) {
|
| 267 |
|
|
j.m.Lock()
|
| 268 |
|
|
defer j.m.Unlock()
|
| 269 |
|
|
j.perURL[u.Host] = cookies
|
| 270 |
|
|
}
|
| 271 |
|
|
|
| 272 |
|
|
func (j *TestJar) Cookies(u *url.URL) []*Cookie {
|
| 273 |
|
|
j.m.Lock()
|
| 274 |
|
|
defer j.m.Unlock()
|
| 275 |
|
|
return j.perURL[u.Host]
|
| 276 |
|
|
}
|
| 277 |
|
|
|
| 278 |
|
|
func TestRedirectCookiesOnRequest(t *testing.T) {
|
| 279 |
|
|
var ts *httptest.Server
|
| 280 |
|
|
ts = httptest.NewServer(echoCookiesRedirectHandler)
|
| 281 |
|
|
defer ts.Close()
|
| 282 |
|
|
c := &Client{}
|
| 283 |
|
|
req, _ := NewRequest("GET", ts.URL, nil)
|
| 284 |
|
|
req.AddCookie(expectedCookies[0])
|
| 285 |
|
|
// TODO: Uncomment when an implementation of a RFC6265 cookie jar lands.
|
| 286 |
|
|
_ = c
|
| 287 |
|
|
// resp, _ := c.Do(req)
|
| 288 |
|
|
// matchReturnedCookies(t, expectedCookies, resp.Cookies())
|
| 289 |
|
|
|
| 290 |
|
|
req, _ = NewRequest("GET", ts.URL, nil)
|
| 291 |
|
|
// resp, _ = c.Do(req)
|
| 292 |
|
|
// matchReturnedCookies(t, expectedCookies[1:], resp.Cookies())
|
| 293 |
|
|
}
|
| 294 |
|
|
|
| 295 |
|
|
func TestRedirectCookiesJar(t *testing.T) {
|
| 296 |
|
|
var ts *httptest.Server
|
| 297 |
|
|
ts = httptest.NewServer(echoCookiesRedirectHandler)
|
| 298 |
|
|
defer ts.Close()
|
| 299 |
|
|
c := &Client{}
|
| 300 |
|
|
c.Jar = &TestJar{perURL: make(map[string][]*Cookie)}
|
| 301 |
|
|
u, _ := url.Parse(ts.URL)
|
| 302 |
|
|
c.Jar.SetCookies(u, []*Cookie{expectedCookies[0]})
|
| 303 |
|
|
resp, _ := c.Get(ts.URL)
|
| 304 |
|
|
matchReturnedCookies(t, expectedCookies, resp.Cookies())
|
| 305 |
|
|
}
|
| 306 |
|
|
|
| 307 |
|
|
func matchReturnedCookies(t *testing.T, expected, given []*Cookie) {
|
| 308 |
|
|
t.Logf("Received cookies: %v", given)
|
| 309 |
|
|
if len(given) != len(expected) {
|
| 310 |
|
|
t.Errorf("Expected %d cookies, got %d", len(expected), len(given))
|
| 311 |
|
|
}
|
| 312 |
|
|
for _, ec := range expected {
|
| 313 |
|
|
foundC := false
|
| 314 |
|
|
for _, c := range given {
|
| 315 |
|
|
if ec.Name == c.Name && ec.Value == c.Value {
|
| 316 |
|
|
foundC = true
|
| 317 |
|
|
break
|
| 318 |
|
|
}
|
| 319 |
|
|
}
|
| 320 |
|
|
if !foundC {
|
| 321 |
|
|
t.Errorf("Missing cookie %v", ec)
|
| 322 |
|
|
}
|
| 323 |
|
|
}
|
| 324 |
|
|
}
|
| 325 |
|
|
|
| 326 |
|
|
func TestStreamingGet(t *testing.T) {
|
| 327 |
|
|
say := make(chan string)
|
| 328 |
|
|
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
|
| 329 |
|
|
w.(Flusher).Flush()
|
| 330 |
|
|
for str := range say {
|
| 331 |
|
|
w.Write([]byte(str))
|
| 332 |
|
|
w.(Flusher).Flush()
|
| 333 |
|
|
}
|
| 334 |
|
|
}))
|
| 335 |
|
|
defer ts.Close()
|
| 336 |
|
|
|
| 337 |
|
|
c := &Client{}
|
| 338 |
|
|
res, err := c.Get(ts.URL)
|
| 339 |
|
|
if err != nil {
|
| 340 |
|
|
t.Fatal(err)
|
| 341 |
|
|
}
|
| 342 |
|
|
var buf [10]byte
|
| 343 |
|
|
for _, str := range []string{"i", "am", "also", "known", "as", "comet"} {
|
| 344 |
|
|
say <- str
|
| 345 |
|
|
n, err := io.ReadFull(res.Body, buf[0:len(str)])
|
| 346 |
|
|
if err != nil {
|
| 347 |
|
|
t.Fatalf("ReadFull on %q: %v", str, err)
|
| 348 |
|
|
}
|
| 349 |
|
|
if n != len(str) {
|
| 350 |
|
|
t.Fatalf("Receiving %q, only read %d bytes", str, n)
|
| 351 |
|
|
}
|
| 352 |
|
|
got := string(buf[0:n])
|
| 353 |
|
|
if got != str {
|
| 354 |
|
|
t.Fatalf("Expected %q, got %q", str, got)
|
| 355 |
|
|
}
|
| 356 |
|
|
}
|
| 357 |
|
|
close(say)
|
| 358 |
|
|
_, err = io.ReadFull(res.Body, buf[0:1])
|
| 359 |
|
|
if err != io.EOF {
|
| 360 |
|
|
t.Fatalf("at end expected EOF, got %v", err)
|
| 361 |
|
|
}
|
| 362 |
|
|
}
|
| 363 |
|
|
|
| 364 |
|
|
type writeCountingConn struct {
|
| 365 |
|
|
net.Conn
|
| 366 |
|
|
count *int
|
| 367 |
|
|
}
|
| 368 |
|
|
|
| 369 |
|
|
func (c *writeCountingConn) Write(p []byte) (int, error) {
|
| 370 |
|
|
*c.count++
|
| 371 |
|
|
return c.Conn.Write(p)
|
| 372 |
|
|
}
|
| 373 |
|
|
|
| 374 |
|
|
// TestClientWrites verifies that client requests are buffered and we
|
| 375 |
|
|
// don't send a TCP packet per line of the http request + body.
|
| 376 |
|
|
func TestClientWrites(t *testing.T) {
|
| 377 |
|
|
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
|
| 378 |
|
|
}))
|
| 379 |
|
|
defer ts.Close()
|
| 380 |
|
|
|
| 381 |
|
|
writes := 0
|
| 382 |
|
|
dialer := func(netz string, addr string) (net.Conn, error) {
|
| 383 |
|
|
c, err := net.Dial(netz, addr)
|
| 384 |
|
|
if err == nil {
|
| 385 |
|
|
c = &writeCountingConn{c, &writes}
|
| 386 |
|
|
}
|
| 387 |
|
|
return c, err
|
| 388 |
|
|
}
|
| 389 |
|
|
c := &Client{Transport: &Transport{Dial: dialer}}
|
| 390 |
|
|
|
| 391 |
|
|
_, err := c.Get(ts.URL)
|
| 392 |
|
|
if err != nil {
|
| 393 |
|
|
t.Fatal(err)
|
| 394 |
|
|
}
|
| 395 |
|
|
if writes != 1 {
|
| 396 |
|
|
t.Errorf("Get request did %d Write calls, want 1", writes)
|
| 397 |
|
|
}
|
| 398 |
|
|
|
| 399 |
|
|
writes = 0
|
| 400 |
|
|
_, err = c.PostForm(ts.URL, url.Values{"foo": {"bar"}})
|
| 401 |
|
|
if err != nil {
|
| 402 |
|
|
t.Fatal(err)
|
| 403 |
|
|
}
|
| 404 |
|
|
if writes != 1 {
|
| 405 |
|
|
t.Errorf("Post request did %d Write calls, want 1", writes)
|
| 406 |
|
|
}
|
| 407 |
|
|
}
|
| 408 |
|
|
|
| 409 |
|
|
func TestClientInsecureTransport(t *testing.T) {
|
| 410 |
|
|
ts := httptest.NewTLSServer(HandlerFunc(func(w ResponseWriter, r *Request) {
|
| 411 |
|
|
w.Write([]byte("Hello"))
|
| 412 |
|
|
}))
|
| 413 |
|
|
defer ts.Close()
|
| 414 |
|
|
|
| 415 |
|
|
// TODO(bradfitz): add tests for skipping hostname checks too?
|
| 416 |
|
|
// would require a new cert for testing, and probably
|
| 417 |
|
|
// redundant with these tests.
|
| 418 |
|
|
for _, insecure := range []bool{true, false} {
|
| 419 |
|
|
tr := &Transport{
|
| 420 |
|
|
TLSClientConfig: &tls.Config{
|
| 421 |
|
|
InsecureSkipVerify: insecure,
|
| 422 |
|
|
},
|
| 423 |
|
|
}
|
| 424 |
|
|
c := &Client{Transport: tr}
|
| 425 |
|
|
_, err := c.Get(ts.URL)
|
| 426 |
|
|
if (err == nil) != insecure {
|
| 427 |
|
|
t.Errorf("insecure=%v: got unexpected err=%v", insecure, err)
|
| 428 |
|
|
}
|
| 429 |
|
|
}
|
| 430 |
|
|
}
|
| 431 |
|
|
|
| 432 |
|
|
func TestClientErrorWithRequestURI(t *testing.T) {
|
| 433 |
|
|
req, _ := NewRequest("GET", "http://localhost:1234/", nil)
|
| 434 |
|
|
req.RequestURI = "/this/field/is/illegal/and/should/error/"
|
| 435 |
|
|
_, err := DefaultClient.Do(req)
|
| 436 |
|
|
if err == nil {
|
| 437 |
|
|
t.Fatalf("expected an error")
|
| 438 |
|
|
}
|
| 439 |
|
|
if !strings.Contains(err.Error(), "RequestURI") {
|
| 440 |
|
|
t.Errorf("wanted error mentioning RequestURI; got error: %v", err)
|
| 441 |
|
|
}
|
| 442 |
|
|
}
|
