/* Parts of target interface that deal with accessing memory and memory-like
|
/* Parts of target interface that deal with accessing memory and memory-like
|
objects.
|
objects.
|
|
|
Copyright (C) 2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
|
Copyright (C) 2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
|
|
|
This file is part of GDB.
|
This file is part of GDB.
|
|
|
This program is free software; you can redistribute it and/or modify
|
This program is free software; you can redistribute it and/or modify
|
it under the terms of the GNU General Public License as published by
|
it under the terms of the GNU General Public License as published by
|
the Free Software Foundation; either version 3 of the License, or
|
the Free Software Foundation; either version 3 of the License, or
|
(at your option) any later version.
|
(at your option) any later version.
|
|
|
This program is distributed in the hope that it will be useful,
|
This program is distributed in the hope that it will be useful,
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
GNU General Public License for more details.
|
GNU General Public License for more details.
|
|
|
You should have received a copy of the GNU General Public License
|
You should have received a copy of the GNU General Public License
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
#include "defs.h"
|
#include "defs.h"
|
#include "vec.h"
|
#include "vec.h"
|
#include "target.h"
|
#include "target.h"
|
#include "memory-map.h"
|
#include "memory-map.h"
|
|
|
#include "gdb_assert.h"
|
#include "gdb_assert.h"
|
|
|
#include <stdio.h>
|
#include <stdio.h>
|
#include <sys/time.h>
|
#include <sys/time.h>
|
|
|
static int
|
static int
|
compare_block_starting_address (const void *a, const void *b)
|
compare_block_starting_address (const void *a, const void *b)
|
{
|
{
|
const struct memory_write_request *a_req = a;
|
const struct memory_write_request *a_req = a;
|
const struct memory_write_request *b_req = b;
|
const struct memory_write_request *b_req = b;
|
|
|
if (a_req->begin < b_req->begin)
|
if (a_req->begin < b_req->begin)
|
return -1;
|
return -1;
|
else if (a_req->begin == b_req->begin)
|
else if (a_req->begin == b_req->begin)
|
return 0;
|
return 0;
|
else
|
else
|
return 1;
|
return 1;
|
}
|
}
|
|
|
/* Adds to RESULT all memory write requests from BLOCK that are
|
/* Adds to RESULT all memory write requests from BLOCK that are
|
in [BEGIN, END) range.
|
in [BEGIN, END) range.
|
|
|
If any memory request is only partially in the specified range,
|
If any memory request is only partially in the specified range,
|
that part of the memory request will be added. */
|
that part of the memory request will be added. */
|
|
|
static void
|
static void
|
claim_memory (VEC(memory_write_request_s) *blocks,
|
claim_memory (VEC(memory_write_request_s) *blocks,
|
VEC(memory_write_request_s) **result,
|
VEC(memory_write_request_s) **result,
|
ULONGEST begin,
|
ULONGEST begin,
|
ULONGEST end)
|
ULONGEST end)
|
{
|
{
|
int i;
|
int i;
|
ULONGEST claimed_begin;
|
ULONGEST claimed_begin;
|
ULONGEST claimed_end;
|
ULONGEST claimed_end;
|
struct memory_write_request *r;
|
struct memory_write_request *r;
|
|
|
for (i = 0; VEC_iterate (memory_write_request_s, blocks, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, blocks, i, r); ++i)
|
{
|
{
|
/* If the request doesn't overlap [BEGIN, END), skip it. We
|
/* If the request doesn't overlap [BEGIN, END), skip it. We
|
must handle END == 0 meaning the top of memory; we don't yet
|
must handle END == 0 meaning the top of memory; we don't yet
|
check for R->end == 0, which would also mean the top of
|
check for R->end == 0, which would also mean the top of
|
memory, but there's an assertion in
|
memory, but there's an assertion in
|
target_write_memory_blocks which checks for that. */
|
target_write_memory_blocks which checks for that. */
|
|
|
if (begin >= r->end)
|
if (begin >= r->end)
|
continue;
|
continue;
|
if (end != 0 && end <= r->begin)
|
if (end != 0 && end <= r->begin)
|
continue;
|
continue;
|
|
|
claimed_begin = max (begin, r->begin);
|
claimed_begin = max (begin, r->begin);
|
if (end == 0)
|
if (end == 0)
|
claimed_end = r->end;
|
claimed_end = r->end;
|
else
|
else
|
claimed_end = min (end, r->end);
|
claimed_end = min (end, r->end);
|
|
|
if (claimed_begin == r->begin && claimed_end == r->end)
|
if (claimed_begin == r->begin && claimed_end == r->end)
|
VEC_safe_push (memory_write_request_s, *result, r);
|
VEC_safe_push (memory_write_request_s, *result, r);
|
else
|
else
|
{
|
{
|
struct memory_write_request *n =
|
struct memory_write_request *n =
|
VEC_safe_push (memory_write_request_s, *result, NULL);
|
VEC_safe_push (memory_write_request_s, *result, NULL);
|
*n = *r;
|
*n = *r;
|
n->begin = claimed_begin;
|
n->begin = claimed_begin;
|
n->end = claimed_end;
|
n->end = claimed_end;
|
n->data += claimed_begin - r->begin;
|
n->data += claimed_begin - r->begin;
|
}
|
}
|
}
|
}
|
}
|
}
|
|
|
/* Given a vector of struct memory_write_request objects in BLOCKS,
|
/* Given a vector of struct memory_write_request objects in BLOCKS,
|
add memory requests for flash memory into FLASH_BLOCKS, and for
|
add memory requests for flash memory into FLASH_BLOCKS, and for
|
regular memory to REGULAR_BLOCKS. */
|
regular memory to REGULAR_BLOCKS. */
|
|
|
static void
|
static void
|
split_regular_and_flash_blocks (VEC(memory_write_request_s) *blocks,
|
split_regular_and_flash_blocks (VEC(memory_write_request_s) *blocks,
|
VEC(memory_write_request_s) **regular_blocks,
|
VEC(memory_write_request_s) **regular_blocks,
|
VEC(memory_write_request_s) **flash_blocks)
|
VEC(memory_write_request_s) **flash_blocks)
|
{
|
{
|
struct mem_region *region;
|
struct mem_region *region;
|
CORE_ADDR cur_address;
|
CORE_ADDR cur_address;
|
|
|
/* This implementation runs in O(length(regions)*length(blocks)) time.
|
/* This implementation runs in O(length(regions)*length(blocks)) time.
|
However, in most cases the number of blocks will be small, so this does
|
However, in most cases the number of blocks will be small, so this does
|
not matter.
|
not matter.
|
|
|
Note also that it's extremely unlikely that a memory write request
|
Note also that it's extremely unlikely that a memory write request
|
will span more than one memory region, however for safety we handle
|
will span more than one memory region, however for safety we handle
|
such situations. */
|
such situations. */
|
|
|
cur_address = 0;
|
cur_address = 0;
|
while (1)
|
while (1)
|
{
|
{
|
VEC(memory_write_request_s) **r;
|
VEC(memory_write_request_s) **r;
|
region = lookup_mem_region (cur_address);
|
region = lookup_mem_region (cur_address);
|
|
|
r = region->attrib.mode == MEM_FLASH ? flash_blocks : regular_blocks;
|
r = region->attrib.mode == MEM_FLASH ? flash_blocks : regular_blocks;
|
cur_address = region->hi;
|
cur_address = region->hi;
|
claim_memory (blocks, r, region->lo, region->hi);
|
claim_memory (blocks, r, region->lo, region->hi);
|
|
|
if (cur_address == 0)
|
if (cur_address == 0)
|
break;
|
break;
|
}
|
}
|
}
|
}
|
|
|
/* Given an ADDRESS, if BEGIN is non-NULL this function sets *BEGIN
|
/* Given an ADDRESS, if BEGIN is non-NULL this function sets *BEGIN
|
to the start of the flash block containing the address. Similarly,
|
to the start of the flash block containing the address. Similarly,
|
if END is non-NULL *END will be set to the address one past the end
|
if END is non-NULL *END will be set to the address one past the end
|
of the block containing the address. */
|
of the block containing the address. */
|
|
|
static void
|
static void
|
block_boundaries (CORE_ADDR address, CORE_ADDR *begin, CORE_ADDR *end)
|
block_boundaries (CORE_ADDR address, CORE_ADDR *begin, CORE_ADDR *end)
|
{
|
{
|
struct mem_region *region;
|
struct mem_region *region;
|
unsigned blocksize;
|
unsigned blocksize;
|
|
|
region = lookup_mem_region (address);
|
region = lookup_mem_region (address);
|
gdb_assert (region->attrib.mode == MEM_FLASH);
|
gdb_assert (region->attrib.mode == MEM_FLASH);
|
blocksize = region->attrib.blocksize;
|
blocksize = region->attrib.blocksize;
|
if (begin)
|
if (begin)
|
*begin = address / blocksize * blocksize;
|
*begin = address / blocksize * blocksize;
|
if (end)
|
if (end)
|
*end = (address + blocksize - 1) / blocksize * blocksize;
|
*end = (address + blocksize - 1) / blocksize * blocksize;
|
}
|
}
|
|
|
/* Given the list of memory requests to be WRITTEN, this function
|
/* Given the list of memory requests to be WRITTEN, this function
|
returns write requests covering each group of flash blocks which must
|
returns write requests covering each group of flash blocks which must
|
be erased. */
|
be erased. */
|
|
|
static VEC(memory_write_request_s) *
|
static VEC(memory_write_request_s) *
|
blocks_to_erase (VEC(memory_write_request_s) *written)
|
blocks_to_erase (VEC(memory_write_request_s) *written)
|
{
|
{
|
unsigned i;
|
unsigned i;
|
struct memory_write_request *ptr;
|
struct memory_write_request *ptr;
|
|
|
VEC(memory_write_request_s) *result = NULL;
|
VEC(memory_write_request_s) *result = NULL;
|
|
|
for (i = 0; VEC_iterate (memory_write_request_s, written, i, ptr); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, written, i, ptr); ++i)
|
{
|
{
|
CORE_ADDR begin, end;
|
CORE_ADDR begin, end;
|
|
|
block_boundaries (ptr->begin, &begin, 0);
|
block_boundaries (ptr->begin, &begin, 0);
|
block_boundaries (ptr->end - 1, 0, &end);
|
block_boundaries (ptr->end - 1, 0, &end);
|
|
|
if (!VEC_empty (memory_write_request_s, result)
|
if (!VEC_empty (memory_write_request_s, result)
|
&& VEC_last (memory_write_request_s, result)->end >= begin)
|
&& VEC_last (memory_write_request_s, result)->end >= begin)
|
{
|
{
|
VEC_last (memory_write_request_s, result)->end = end;
|
VEC_last (memory_write_request_s, result)->end = end;
|
}
|
}
|
else
|
else
|
{
|
{
|
struct memory_write_request *n =
|
struct memory_write_request *n =
|
VEC_safe_push (memory_write_request_s, result, NULL);
|
VEC_safe_push (memory_write_request_s, result, NULL);
|
memset (n, 0, sizeof (struct memory_write_request));
|
memset (n, 0, sizeof (struct memory_write_request));
|
n->begin = begin;
|
n->begin = begin;
|
n->end = end;
|
n->end = end;
|
}
|
}
|
}
|
}
|
|
|
return result;
|
return result;
|
}
|
}
|
|
|
/* Given ERASED_BLOCKS, a list of blocks that will be erased with
|
/* Given ERASED_BLOCKS, a list of blocks that will be erased with
|
flash erase commands, and WRITTEN_BLOCKS, the list of memory
|
flash erase commands, and WRITTEN_BLOCKS, the list of memory
|
addresses that will be written, compute the set of memory addresses
|
addresses that will be written, compute the set of memory addresses
|
that will be erased but not rewritten (e.g. padding within a block
|
that will be erased but not rewritten (e.g. padding within a block
|
which is only partially filled by "load"). */
|
which is only partially filled by "load"). */
|
|
|
static VEC(memory_write_request_s) *
|
static VEC(memory_write_request_s) *
|
compute_garbled_blocks (VEC(memory_write_request_s) *erased_blocks,
|
compute_garbled_blocks (VEC(memory_write_request_s) *erased_blocks,
|
VEC(memory_write_request_s) *written_blocks)
|
VEC(memory_write_request_s) *written_blocks)
|
{
|
{
|
VEC(memory_write_request_s) *result = NULL;
|
VEC(memory_write_request_s) *result = NULL;
|
|
|
unsigned i, j;
|
unsigned i, j;
|
unsigned je = VEC_length (memory_write_request_s, written_blocks);
|
unsigned je = VEC_length (memory_write_request_s, written_blocks);
|
struct memory_write_request *erased_p;
|
struct memory_write_request *erased_p;
|
|
|
/* Look at each erased memory_write_request in turn, and
|
/* Look at each erased memory_write_request in turn, and
|
see what part of it is subsequently written to.
|
see what part of it is subsequently written to.
|
|
|
This implementation is O(length(erased) * length(written)). If
|
This implementation is O(length(erased) * length(written)). If
|
the lists are sorted at this point it could be rewritten more
|
the lists are sorted at this point it could be rewritten more
|
efficiently, but the complexity is not generally worthwhile. */
|
efficiently, but the complexity is not generally worthwhile. */
|
|
|
for (i = 0;
|
for (i = 0;
|
VEC_iterate (memory_write_request_s, erased_blocks, i, erased_p);
|
VEC_iterate (memory_write_request_s, erased_blocks, i, erased_p);
|
++i)
|
++i)
|
{
|
{
|
/* Make a deep copy -- it will be modified inside the loop, but
|
/* Make a deep copy -- it will be modified inside the loop, but
|
we don't want to modify original vector. */
|
we don't want to modify original vector. */
|
struct memory_write_request erased = *erased_p;
|
struct memory_write_request erased = *erased_p;
|
|
|
for (j = 0; j != je;)
|
for (j = 0; j != je;)
|
{
|
{
|
struct memory_write_request *written
|
struct memory_write_request *written
|
= VEC_index (memory_write_request_s,
|
= VEC_index (memory_write_request_s,
|
written_blocks, j);
|
written_blocks, j);
|
|
|
/* Now try various cases. */
|
/* Now try various cases. */
|
|
|
/* If WRITTEN is fully to the left of ERASED, check the next
|
/* If WRITTEN is fully to the left of ERASED, check the next
|
written memory_write_request. */
|
written memory_write_request. */
|
if (written->end <= erased.begin)
|
if (written->end <= erased.begin)
|
{
|
{
|
++j;
|
++j;
|
continue;
|
continue;
|
}
|
}
|
|
|
/* If WRITTEN is fully to the right of ERASED, then ERASED
|
/* If WRITTEN is fully to the right of ERASED, then ERASED
|
is not written at all. WRITTEN might affect other
|
is not written at all. WRITTEN might affect other
|
blocks. */
|
blocks. */
|
if (written->begin >= erased.end)
|
if (written->begin >= erased.end)
|
{
|
{
|
VEC_safe_push (memory_write_request_s, result, &erased);
|
VEC_safe_push (memory_write_request_s, result, &erased);
|
goto next_erased;
|
goto next_erased;
|
}
|
}
|
|
|
/* If all of ERASED is completely written, we can move on to
|
/* If all of ERASED is completely written, we can move on to
|
the next erased region. */
|
the next erased region. */
|
if (written->begin <= erased.begin
|
if (written->begin <= erased.begin
|
&& written->end >= erased.end)
|
&& written->end >= erased.end)
|
{
|
{
|
goto next_erased;
|
goto next_erased;
|
}
|
}
|
|
|
/* If there is an unwritten part at the beginning of ERASED,
|
/* If there is an unwritten part at the beginning of ERASED,
|
then we should record that part and try this inner loop
|
then we should record that part and try this inner loop
|
again for the remainder. */
|
again for the remainder. */
|
if (written->begin > erased.begin)
|
if (written->begin > erased.begin)
|
{
|
{
|
struct memory_write_request *n =
|
struct memory_write_request *n =
|
VEC_safe_push (memory_write_request_s, result, NULL);
|
VEC_safe_push (memory_write_request_s, result, NULL);
|
memset (n, 0, sizeof (struct memory_write_request));
|
memset (n, 0, sizeof (struct memory_write_request));
|
n->begin = erased.begin;
|
n->begin = erased.begin;
|
n->end = written->begin;
|
n->end = written->begin;
|
erased.begin = written->begin;
|
erased.begin = written->begin;
|
continue;
|
continue;
|
}
|
}
|
|
|
/* If there is an unwritten part at the end of ERASED, we
|
/* If there is an unwritten part at the end of ERASED, we
|
forget about the part that was written to and wait to see
|
forget about the part that was written to and wait to see
|
if the next write request writes more of ERASED. We can't
|
if the next write request writes more of ERASED. We can't
|
push it yet. */
|
push it yet. */
|
if (written->end < erased.end)
|
if (written->end < erased.end)
|
{
|
{
|
erased.begin = written->end;
|
erased.begin = written->end;
|
++j;
|
++j;
|
continue;
|
continue;
|
}
|
}
|
}
|
}
|
|
|
/* If we ran out of write requests without doing anything about
|
/* If we ran out of write requests without doing anything about
|
ERASED, then that means it's really erased. */
|
ERASED, then that means it's really erased. */
|
VEC_safe_push (memory_write_request_s, result, &erased);
|
VEC_safe_push (memory_write_request_s, result, &erased);
|
|
|
next_erased:
|
next_erased:
|
;
|
;
|
}
|
}
|
|
|
return result;
|
return result;
|
}
|
}
|
|
|
static void
|
static void
|
cleanup_request_data (void *p)
|
cleanup_request_data (void *p)
|
{
|
{
|
VEC(memory_write_request_s) **v = p;
|
VEC(memory_write_request_s) **v = p;
|
struct memory_write_request *r;
|
struct memory_write_request *r;
|
int i;
|
int i;
|
|
|
for (i = 0; VEC_iterate (memory_write_request_s, *v, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, *v, i, r); ++i)
|
xfree (r->data);
|
xfree (r->data);
|
}
|
}
|
|
|
static void
|
static void
|
cleanup_write_requests_vector (void *p)
|
cleanup_write_requests_vector (void *p)
|
{
|
{
|
VEC(memory_write_request_s) **v = p;
|
VEC(memory_write_request_s) **v = p;
|
VEC_free (memory_write_request_s, *v);
|
VEC_free (memory_write_request_s, *v);
|
}
|
}
|
|
|
int
|
int
|
target_write_memory_blocks (VEC(memory_write_request_s) *requests,
|
target_write_memory_blocks (VEC(memory_write_request_s) *requests,
|
enum flash_preserve_mode preserve_flash_p,
|
enum flash_preserve_mode preserve_flash_p,
|
void (*progress_cb) (ULONGEST, void *))
|
void (*progress_cb) (ULONGEST, void *))
|
{
|
{
|
struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
|
struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
|
VEC(memory_write_request_s) *blocks = VEC_copy (memory_write_request_s,
|
VEC(memory_write_request_s) *blocks = VEC_copy (memory_write_request_s,
|
requests);
|
requests);
|
unsigned i;
|
unsigned i;
|
int err = 0;
|
int err = 0;
|
struct memory_write_request *r;
|
struct memory_write_request *r;
|
VEC(memory_write_request_s) *regular = NULL;
|
VEC(memory_write_request_s) *regular = NULL;
|
VEC(memory_write_request_s) *flash = NULL;
|
VEC(memory_write_request_s) *flash = NULL;
|
VEC(memory_write_request_s) *erased, *garbled;
|
VEC(memory_write_request_s) *erased, *garbled;
|
|
|
/* END == 0 would represent wraparound: a write to the very last
|
/* END == 0 would represent wraparound: a write to the very last
|
byte of the address space. This file was not written with that
|
byte of the address space. This file was not written with that
|
possibility in mind. This is fixable, but a lot of work for a
|
possibility in mind. This is fixable, but a lot of work for a
|
rare problem; so for now, fail noisily here instead of obscurely
|
rare problem; so for now, fail noisily here instead of obscurely
|
later. */
|
later. */
|
for (i = 0; VEC_iterate (memory_write_request_s, requests, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, requests, i, r); ++i)
|
gdb_assert (r->end != 0);
|
gdb_assert (r->end != 0);
|
|
|
make_cleanup (cleanup_write_requests_vector, &blocks);
|
make_cleanup (cleanup_write_requests_vector, &blocks);
|
|
|
/* Sort the blocks by their start address. */
|
/* Sort the blocks by their start address. */
|
qsort (VEC_address (memory_write_request_s, blocks),
|
qsort (VEC_address (memory_write_request_s, blocks),
|
VEC_length (memory_write_request_s, blocks),
|
VEC_length (memory_write_request_s, blocks),
|
sizeof (struct memory_write_request), compare_block_starting_address);
|
sizeof (struct memory_write_request), compare_block_starting_address);
|
|
|
/* Split blocks into list of regular memory blocks,
|
/* Split blocks into list of regular memory blocks,
|
and list of flash memory blocks. */
|
and list of flash memory blocks. */
|
make_cleanup (cleanup_write_requests_vector, ®ular);
|
make_cleanup (cleanup_write_requests_vector, ®ular);
|
make_cleanup (cleanup_write_requests_vector, &flash);
|
make_cleanup (cleanup_write_requests_vector, &flash);
|
split_regular_and_flash_blocks (blocks, ®ular, &flash);
|
split_regular_and_flash_blocks (blocks, ®ular, &flash);
|
|
|
/* If a variable is added to forbid flash write, even during "load",
|
/* If a variable is added to forbid flash write, even during "load",
|
it should be checked here. Similarly, if this function is used
|
it should be checked here. Similarly, if this function is used
|
for other situations besides "load" in which writing to flash
|
for other situations besides "load" in which writing to flash
|
is undesirable, that should be checked here. */
|
is undesirable, that should be checked here. */
|
|
|
/* Find flash blocks to erase. */
|
/* Find flash blocks to erase. */
|
erased = blocks_to_erase (flash);
|
erased = blocks_to_erase (flash);
|
make_cleanup (cleanup_write_requests_vector, &erased);
|
make_cleanup (cleanup_write_requests_vector, &erased);
|
|
|
/* Find what flash regions will be erased, and not overwritten; then
|
/* Find what flash regions will be erased, and not overwritten; then
|
either preserve or discard the old contents. */
|
either preserve or discard the old contents. */
|
garbled = compute_garbled_blocks (erased, flash);
|
garbled = compute_garbled_blocks (erased, flash);
|
make_cleanup (cleanup_request_data, &garbled);
|
make_cleanup (cleanup_request_data, &garbled);
|
make_cleanup (cleanup_write_requests_vector, &garbled);
|
make_cleanup (cleanup_write_requests_vector, &garbled);
|
|
|
if (!VEC_empty (memory_write_request_s, garbled))
|
if (!VEC_empty (memory_write_request_s, garbled))
|
{
|
{
|
if (preserve_flash_p == flash_preserve)
|
if (preserve_flash_p == flash_preserve)
|
{
|
{
|
struct memory_write_request *r;
|
struct memory_write_request *r;
|
|
|
/* Read in regions that must be preserved and add them to
|
/* Read in regions that must be preserved and add them to
|
the list of blocks we read. */
|
the list of blocks we read. */
|
for (i = 0; VEC_iterate (memory_write_request_s, garbled, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, garbled, i, r); ++i)
|
{
|
{
|
gdb_assert (r->data == NULL);
|
gdb_assert (r->data == NULL);
|
r->data = xmalloc (r->end - r->begin);
|
r->data = xmalloc (r->end - r->begin);
|
err = target_read_memory (r->begin, r->data, r->end - r->begin);
|
err = target_read_memory (r->begin, r->data, r->end - r->begin);
|
if (err != 0)
|
if (err != 0)
|
goto out;
|
goto out;
|
|
|
VEC_safe_push (memory_write_request_s, flash, r);
|
VEC_safe_push (memory_write_request_s, flash, r);
|
}
|
}
|
|
|
qsort (VEC_address (memory_write_request_s, flash),
|
qsort (VEC_address (memory_write_request_s, flash),
|
VEC_length (memory_write_request_s, flash),
|
VEC_length (memory_write_request_s, flash),
|
sizeof (struct memory_write_request), compare_block_starting_address);
|
sizeof (struct memory_write_request), compare_block_starting_address);
|
}
|
}
|
}
|
}
|
|
|
/* We could coalesce adjacent memory blocks here, to reduce the
|
/* We could coalesce adjacent memory blocks here, to reduce the
|
number of write requests for small sections. However, we would
|
number of write requests for small sections. However, we would
|
have to reallocate and copy the data pointers, which could be
|
have to reallocate and copy the data pointers, which could be
|
large; large sections are more common in loadable objects than
|
large; large sections are more common in loadable objects than
|
large numbers of small sections (although the reverse can be true
|
large numbers of small sections (although the reverse can be true
|
in object files). So, we issue at least one write request per
|
in object files). So, we issue at least one write request per
|
passed struct memory_write_request. The remote stub will still
|
passed struct memory_write_request. The remote stub will still
|
have the opportunity to batch flash requests. */
|
have the opportunity to batch flash requests. */
|
|
|
/* Write regular blocks. */
|
/* Write regular blocks. */
|
for (i = 0; VEC_iterate (memory_write_request_s, regular, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, regular, i, r); ++i)
|
{
|
{
|
LONGEST len;
|
LONGEST len;
|
|
|
len = target_write_with_progress (current_target.beneath,
|
len = target_write_with_progress (current_target.beneath,
|
TARGET_OBJECT_MEMORY, NULL,
|
TARGET_OBJECT_MEMORY, NULL,
|
r->data, r->begin, r->end - r->begin,
|
r->data, r->begin, r->end - r->begin,
|
progress_cb, r->baton);
|
progress_cb, r->baton);
|
if (len < (LONGEST) (r->end - r->begin))
|
if (len < (LONGEST) (r->end - r->begin))
|
{
|
{
|
/* Call error? */
|
/* Call error? */
|
err = -1;
|
err = -1;
|
goto out;
|
goto out;
|
}
|
}
|
}
|
}
|
|
|
if (!VEC_empty (memory_write_request_s, erased))
|
if (!VEC_empty (memory_write_request_s, erased))
|
{
|
{
|
/* Erase all pages. */
|
/* Erase all pages. */
|
for (i = 0; VEC_iterate (memory_write_request_s, erased, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, erased, i, r); ++i)
|
target_flash_erase (r->begin, r->end - r->begin);
|
target_flash_erase (r->begin, r->end - r->begin);
|
|
|
/* Write flash data. */
|
/* Write flash data. */
|
for (i = 0; VEC_iterate (memory_write_request_s, flash, i, r); ++i)
|
for (i = 0; VEC_iterate (memory_write_request_s, flash, i, r); ++i)
|
{
|
{
|
LONGEST len;
|
LONGEST len;
|
|
|
len = target_write_with_progress (¤t_target,
|
len = target_write_with_progress (¤t_target,
|
TARGET_OBJECT_FLASH, NULL,
|
TARGET_OBJECT_FLASH, NULL,
|
r->data, r->begin, r->end - r->begin,
|
r->data, r->begin, r->end - r->begin,
|
progress_cb, r->baton);
|
progress_cb, r->baton);
|
if (len < (LONGEST) (r->end - r->begin))
|
if (len < (LONGEST) (r->end - r->begin))
|
error (_("Error writing data to flash"));
|
error (_("Error writing data to flash"));
|
}
|
}
|
|
|
target_flash_done ();
|
target_flash_done ();
|
}
|
}
|
|
|
out:
|
out:
|
do_cleanups (back_to);
|
do_cleanups (back_to);
|
|
|
return err;
|
return err;
|
}
|
}
|
|
|
