URL
https://opencores.org/ocsvn/openrisc_me/openrisc_me/trunk
Subversion Repositories openrisc_me
[/] [openrisc/] [trunk/] [gnu-src/] [gcc-4.5.1/] [gcc/] [ChangeLog.ptr] - Rev 280
Compare with Previous | Blame | View Log
2007-06-14 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 1257332007-06-14 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-vrp.c (compare_values_warnv): Fix spelling/grammermistakes(extract_range_from_binary_expr): Likewise.* doc/c-tree.texi (POINTER_PLUS_EXPR): Likewise.* tree-ssa-loop-niter.c (assert_loop_rolls_lt): Add verticalwhitespace.* tree-pretty-print.c (op_symbol_code <case POINTER_PLUS_EXPR>):Change print out to "+".* tree-scalar-evolution.c (instantiate_parameters_1):Use chrec_type instead of TREE_TYPE.* builtins.c (expand_builtin_strcat): Fix vertical whitespace.(std_expand_builtin_va_start): Fix whitespace.(fold_builtin_strstr): Use size_int instead of build_int_cst (sizetype.(fold_builtin_strchr): Likewise.(fold_builtin_strrchr): Likewise.(fold_builtin_strpbrk): Likewise.* fold-const.c (try_move_mult_to_index): Fix spelling/grammermistakes.(fold_to_nonsharp_ineq_using_bound): Merge the two ifs at the end.(fold_binary): Fix spelling/grammer mistakes.* tree-ssa-ccp.c (maybe_fold_stmt_addition): Assert that onlya POINTER_PLUS_EXPR is passed in.* tree-ssa-loop-ivopts.c (determine_base_object):Fix spelling/grammer mistakes.* expr.c (expand_expr_real_1): Likewise.* tree-data-ref.c (split_constant_offset): Likewise.* c-typeck.c (build_unary_op): Use fold_convert instead of convertfor converting to sizetype.* tree.def (POINTER_PLUS_EXPR): Fix comment.* tree-ssa-forwprop.c (forward_propagate_addr_expr_1):Fix spelling/grammer mistakes.(phiprop_insert_phi): Likewise.* c-common.c (pointer_int_sum): Remove FIXME aboutPOINTER_MINUS_EXPR.2007-06-13 Andrew Pinski <andrew_pinski@playstation.sony.com>* expr.c (expand_expr_real_1 <case POINTER_PLUS_EXPR>): Remove assertfor checking the modes of the operands are the same.2007-06-12 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/sparc/sparc.c (sparc_gimplify_va_arg): Use POINTER_PLUS_EXPRinstead of PLUS_EXPR when the operand was a pointer. Don't create aBIT_AND_EXPR for pointer types.2007-06-12 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/mips/mips.c (mips_va_start): Use POINTER_PLUS_EXPRfor pointers.(mips_gimplify_va_arg_expr): Likewise.Don't create BIT_AND_EXPR in a pointer type.2007-06-12 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 1256582007-06-11 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 1256112007-06-07 Andrew Pinski <andrew_pinski@playstation.sony.com>* matrix-reorg.c (collect_data_for_malloc_call): Stmtwill now only be either INDIRECT_REF and POINTER_PLUS_EXPR.Offset only holds something for PLUS_EXPR.(ssa_accessed_in_tree): Handle POINTER_PLUS_EXPR just asa PLUS_EXPR.(analyze_transpose): POINTER_PLUS_EXPR will only show up nowand not PLUS_EXPR.(analyze_accesses_for_modify_stmt): Likewise.Remove comment about the type being integral type as it iswrong now.(analyze_matrix_accesses): Handle POINTER_PLUS_EXPR asPLUS_EXPR.(transform_access_sites): POINTER_PLUS_EXPR will only show up nowand not PLUS_EXPR.Correct the type which the artimentic is done in (is nowsizetype).Reindent one loop.2007-06-07 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/ia64/ia64.c (ia64_gimplify_va_arg): UsePOINTER_PLUS_EXPR for pointers and create theBIT_AND_EXPR in sizetype.* config/s390/s390.c (s390_va_start): Use POINTER_PLUS_EXPRfor pointers instead of PLUS_EXPR.(s390_gimplify_va_arg): Likewise.2007-06-07 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/frv/frv.c (frv_expand_builtin_va_start): Use sizetypewith make_tree, instead of a pointer type.* config/pa/pa.c (reloc_needed): Handle POINTER_PLUS_EXPRas PLUS_EXPR/MINUS_EXPR.(hppa_gimplify_va_arg_expr): Don't create MINUS_EXPR orPLUS_EXPR for pointers, instead use POINTER_PLUS_EXPR.Don't use BIT_AND_EXPR on a pointer type, convert theexpression to sizetype first.2007-06-06 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-ssa-forwprop.c(forward_propagate_addr_into_variable_array_index):Don't expect a statement for the size 1 case.Use the offset variable for the size 1 case.Look through use-def chains to find the mutliplyfor the non size 1 case.(forward_propagate_addr_expr_1): Callforward_propagate_addr_into_variable_array_index withthe SSA_NAME instead of the statement.2007-06-06 Andrew Pinski <andrew_pinski@playstation.sony.com>PR tree-opt/32225* tree-scalar-evolution.c (follow_ssa_edge_in_rhs <casePOINTER_PLUS_EXPR>): Do not change type_rhs.(follow_ssa_edge_in_rhs <case POINTER_PLUS_EXPR, case PLUS_EXPR>):Use the code of the orginal expression instead of just PLUS_EXPR.Also use type_rhs where TREE_TYPE (rhs) was used (reverting backto the trunk).2007-06-03 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-predcom.c (ref_at_iteration): If we have a pointertype do the multiplication in sizetype.2007-06-01 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 1252852007-05-31 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-vrp.c (extract_range_from_binary_expr): HandleMIN_EXPR/MAX_EXPR for pointers type.PR tree-opt/32167* tree-chrec.c (chrec_fold_plus): When eitheroperand is zero, convert the other operand.2007-05-30 Andrew Pinski <andrew_pinski@playstation.sony.com>* builtins.c (std_expand_builtin_va_start): Usesizetype for the call to make_tree and then convertto the pointer type.2007-05-30 Andrew Pinski <andrew_pinski@playstation.sony.com>PR tree-op/32145* tree-vrp.c (extract_range_from_assert): CreatePOINTER_PLUS_EXPR for pointer types.PR tree-opt/32144* tree-chrec.c (chrec_fold_plus_poly_poly): If thefirst chrec is a pointer type, then the second shouldbe sizetype and not the first's type.2007-05-28 Andrew Pinski <andrew_pinski@playstation.sony.com>* fold-const.c (try_move_mult_to_index):Say why we strip the nops.(fold_unary <case NOP_EXPR>): RemoveTODO as we cannot get that case.* tree-chrec.c (chrec_fold_plus):Cleanup the code to chose whichtree code is used.(chrec_convert_rhs): Add comment onwhy the increment is sizetype forpointers.* tree-mudflap.c (mf_xform_derefs_1):Use size_int instead of build_int_cst.* tree-ssa-loop-prefetch.c (issue_prefetch_ref): Likewise.2007-05-21 Andrew Pinski <andrew_pinski@playstation.sony.com>PR tree-opt/32015* tree.c (build2_stat): Make sure thatMULT_EXPR is not used with pointers.* tree-chrec.c (chrec_apply): Use chrec_convert_rhson the argument x instead of chrec_convert.2007-05-20 Kaz Kojima <kkojima@gcc.gnu.org>* config/sh/sh.c (sh_va_start): Call make_tree with sizetypeand convert its result to a pointer type. Use POINTER_PLUS_EXPRfor the pointer additions and also use size_int for the offsets.(sh_gimplify_va_arg_expr): Use POINTER_PLUS_EXPR for the pointeradditions and also use size_int for the offsets. PerformBIT_AND_EXPR on sizetype arguments.2007-05-15 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-ssa-forwprop (forward_propagate_addr_into_variable_array_index):Don't expect there to be a cast for the index as thatdoes not exist anymore.(forward_propagate_addr_expr_1): Check forPOINTER_PLUS_EXPR instead of PLUS_EXPR.Don't check for the first operand of thePOINTER_PLUS_EXPR was the index as itcannot be.2007-05-15 Richard Guenther <rguenther@suse.de>* config/i386/i386.c (ix86_gimplify_va_arg): Use POINTER_PLUS_EXPR,perform BIT_AND_EXPR on sizetype arguments.2007-05-15 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/rs6000/rs6000.c (rs6000_va_start): Use POINTER_PLUS_EXPRinstead of PLUS_EXPR for pointer addition.(rs6000_va_start): Likewise.Also use sizetype for the offset.* tree-stdarg.c (va_list_counter_bump): Check for PLUS_EXPRand POINTER_PLUS_EXPR.(check_va_list_escapes): Likewise.2007-05-14 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/i386/i386.c (ix86_va_start): Use POINTER_PLUS_EXPRfor the pointer addition and also use size_int/sizetypefor the offset.(ix86_gimplify_va_arg): Likewise.2007-05-14 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 124657* tree-data-ref.c (split_constant_offset): HandlePOINTER_PLUS_EXPRexactly the same as PLUS_EXPR/MINUS_EXPR except for the offsetneeds to be calcuated using PLUS_EXPR instead ofPOINTER_PLUS_EXPR.* builtins.c (fold_builtin_memchr): Use POINTER_PLUS_EXPRinstead of PLUS_EXPR for adding to a pointer.2006-05-15 Zdenek Dvorak <dvorakz@suse.cz>* tree-ssa-loop-ivopts.c (determine_base_object): Abort for PLUS_EXPRin pointer type.2007-05-12 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-ssa-address.c (tree_mem_ref_addr): When addingthe offset to the base, use POINTER_PLUS_EXPR.2007-05-12 Andrew Pinski <andrew_pinski@playstation.sony.com>* expr.c (expand_expr_addr_expr_1): Call expand_exprfor the offset with the modifier as EXPAND_INITIALIZERif the modifier is EXPAND_INITIALIZER.(expand_expr_real_1 <case INTEGER_CST>): Don't force toa register if we had an overflow.2007-05-10 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 124602.* fold-const.c (extract_array_ref): Make sure the offsetis converted to sizetype.(try_move_mult_to_index): Strip the NOPs from the offset.(fold_binary <case POINTER_PLUS_EXPR>): Convert the secondoperand to sizetype before calling try_move_mult_to_index.* tree-ssa-loop-niter.c (number_of_iterations_lt_to_ne):For pointer types, use sizetype whencreating MINUS_EXPR/PLUS_EXPRs.* tree-ssa-ccp.c (maybe_fold_stmt_indirect): Make surethe offset is converted to sizetype.2007-05-11 Andrew Pinski <andrew_pinski@playstation.sony.com>* config/spu/spu.c (spu_va_start): Create POINTER_PLUS_EXPRinstead of PLUS_EXPR when doing addition on pointertypes. Use sizetype for the second operand.(spu_gimplify_va_arg_expr): Likewise.* tree-ssa.c (tree_ssa_useless_type_conversion_1):Convert the MIN/MAX of the inner type to the outertype before comparing them.2007-05-09 Andrew Pinski <andrew_pinski@playstation.sony.com>Zdenek Dvorak <dvorakz@suse.cz>* fold-const.c (fold_to_nonsharp_ineq_using_bound): Don'tuse a pointer type for MINUS_EXPR.(fold_binary <case MINUS_EXPR>): Fold (PTR0 p+ A) - (PTR1 p+ B)into (PTR0 - PTR1) + (A - B). Fold (PTR0 p+ A) - PTR1 into(PTR0 - PTR1) + A iff (PTR0 - PTR1) simplifies.* tree-chrec.c (chrec_fold_plus_poly_poly): ForPOINTER_PLUS_EXPR, use a different right hand side type.Handle POINTER_PLUS_EXPR like PLUS_EXPR.(chrec_fold_plus_1): Likewise.(convert_affine_scev): Likewise.(chrec_convert_aggressive): Likewise.(chrec_fold_plus): For pointer types, use POINTER_PLUS_EXPRinstead of PLUS_EXPR.(reset_evolution_in_loop): For pointer types, the new_evolshould be sizetype.(chrec_convert_rhs): New function.* tree-chrec.h (chrec_convert_rhs): New prototype.(build_polynomial_chrec): For pointer types, the right handside should be sizetype and not the same as the left hand side.* tree-scalar-evolution.c (add_to_evolution_1): Convert theincrement using chrec_convert_rhs instead of chrec_convert.(follow_ssa_edge_in_rhs): Handle POINTER_PLUS_EXPR likePLUS_EXPR except for the right hand side's type will besizetype.(interpret_rhs_modify_stmt): Handle POINTER_PLUS_EXPR.(fold_used_pointer_cast): Kill.(pointer_offset_p): Kill.(fold_used_pointer): Kill.(pointer_used_p): Kill.(analyze_scalar_evolution_1 <case GIMPLE_MODIFY_STMT>): Don'tcall fold_used_pointer.(instantiate_parameters_1): Convert the incrementusing chrec_convert_rhs instead of chrec_convert.Handle POINTER_PLUS_EXPR as PLUS_EXPR.* tree-ssa-loop-niter.c (split_to_var_and_offset): HandlePOINTER_PLUS_EXPR as PLUS_EXPR.(assert_loop_rolls_lt): For pointer types, use sizetype whencreating MINUS_EXPR/PLUS_EXPRs.(number_of_iterations_le): Likewise.(expand_simple_operations): POINTER_PLUS_EXPR are simple also.(derive_constant_upper_bound): Handle POINTER_PLUS_EXPR justlike PLUS_EXPR and MINUS_EXPR.* tree-data-ref.c (analyze_offset_expr): Likewise.(address_analysis): Handle POINTER_PLUS_EXPR as PLUS_EXPR.(analyze_offset): Handle POINTER_PLUS_EXPR also.(create_data_ref): Convert the incrementusing chrec_convert_rhs instead of chrec_convert.* tree-vect-transform.c (vect_update_ivs_after_vectorizer):For pointer types, create POINTER_PLUS_EXPR instead ofPLUS_EXPR and also create MULT_EXPR in sizetype.2007-05-07 Andrew Pinski <andrew_pinski@playstation.sony.com>* builtins.c (std_gimplify_va_arg_expr): Use fold_build2 forthe creating of POINTER_PLUS_EXPR. For the BIT_AND_EXPR, castthe operands to sizetype first and then cast the BIT_AND_EXPRback to the pointer type.* tree-ssa-address.c (create_mem_ref): Create APOINTER_PLUS_EXPR for one case.* tree.c (const_hash_1): Handle POINTER_PLUS_EXPR same asPLUS_EXPR.(compare_constant): Likewise.(copy_constant): Likewise.(compute_reloc_for_constant): Likewise.(output_addressed_constants): Likewise.2007-05-07 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree.def (POINTER_PLUS_EXPR): The second operandis of type sizetype and not ssizetype.* doc/c-tree.texi (POINTER_PLUS_EXPR): Document.2007-05-06 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-mudflap.c (mf_xform_derefs_1 <case BIT_FIELD_REF>):Add a conversion of ofs to sizetype.(mf_decl_eligible_p): Reformat for length issues.(mf_xform_derefs_1): Likewise.2007-05-06 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree.c (build2_stat): Check to make sure thesecond operand is compatiable with sizetype.2007-05-06 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-cfg.c (verify_expr): Change errormessage about sizetype to be correct.2007-05-06 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 124478.* fold-const.c (fold_unary): Handle for (T1)(X op Y),only p+ as that is the only as that can be handled forbinary operators now. Add a TODO for non pointer typeop's.* gimplifier.c (gimplify_expr): Don't special casePLUS_EXPR. Special case POINTER_PLUS_EXPR instead,remove check for pointer type as it will always bea pointer type now.2007-05-04 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-vrp.c (extract_range_from_binary_expr): HandlePOINTER_PLUS_EXPRs. Assert POINTER_PLUS_EXPR isthe only expression for pointer types.* tree-vect-transform.c (vect_gen_niters_for_prolog_loop):Add a cast when creating byte_misalign.2007-05-04 Andrew Pinski <andrew_pinski@playstation.sony.com>* fold-const.c (fold_binary <case POINTER_PLUS_EXPR>);Add comment on why you get INT +p INT.(fold_binary <case PLUS_EXPR>): Add folding of PTR+INT intoPTR p+ INT.* dwarf2out.c (loc_descriptor_from_tree_1):Handle POINT_PLUS_EXPR as a PLUS_EXPR.2007-05-04 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree-vrp.c (compare_values_warnv): Convert val2 tothe type of val1.* fold-const.c (extract_array_ref): Look forPOINTER_PLUS_EXPR instead of PLUS_EXPR's.* tree-ssa-ccp.c (maybe_fold_stmt_indirect): Likewise.2007-05-02 Andrew Pinski <andrew_pinski@playstation.sony.com>* c-format.c (check_format_arg): Handle POINTER_PLUS_EXPRinstead of PLUS_EXPR of pointer types.2007-05-02 Andrew Pinski <andrew_pinski@playstation.sony.com>* fold-const.c (try_move_mult_to_index): Remove code argumentand replace all uses with PLUS_EXPR.(fold_binary <case POINTER_PLUS_EXR>): Remove code argument.(fold_binary <case PLUS_EXPR>): Don't call try_move_mult_to_index.(fold_binary <case MINUS_EXPR>): Likewise.* tree-ssa-ccp.c (maybe_fold_stmt_indirect): Remove subtractioncase as it is always addition now.(fold_stmt_r): Don't handle PLUS_EXPR/MINUS_EXPR specially.Handle POINTER_PLUS_EXPR like PLUS_EXPR was handled before.2007-05-01 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 124343.* tree-vect-transform.c (bump_vector_ptr): Create a POINTER_PLUS_EXPRinstead of PLUS_EXPR for the pointer increment statement.* expr.c (expand_expr_real_1): Add FIXME/assert for the unhandle casewhere the modes of the two operands are different.2007-02-25 Andrew Pinski <andrew_pinski@playstation.sony.com>Merge mainline, revision 122323.2006-12-14 Zdenek Dvorak <dvorakz@suse.cz>Merge mainline, revision 119860.2006-11-23 Andrew Pinski <andrew_pinski@playstation.sony.com>* tree.def (POINTER_PLUS_EXPR): New tree code.* tree-pretty-print.c (dump_generic_node): HandlePOINTER_PLUS_EXPR.(op_prio): Likewise.(op_symbol_1): Likewise.* optabs.c (optab_for_tree_code): Likewise.* tree-ssa-loop-manip.c (create_iv): Handle pointer basespecially.* tree-tailcall.c (process_assignment): MentionPOINTER_PLUS_EXPR in a TODO comment.* tree.c (build2_stat): Assert when trying to use PLUS_EXPR orMINUS_EXPR with a pointer. Also assert for POINTER_PLUS_EXPRnot used with a pointer and an integer type.* tree-scalar-evolution.c (fold_used_pointer): MentionPOINTER_PLUS_EXPR is what this needs to handle.* builtins.c (get_pointer_alignment): Handle POINTER_PLUS_EXPRinstead of PLUS_EXPR.(expand_builtin_strcat): Create a POINTER_PLUS_EXPR instead ofPLUS_EXPR for pointers.(std_gimplify_va_arg_expr): Likewise.(fold_builtin_memory_op): Likewise.(fold_builtin_strstr): Likewise.(fold_builtin_strchr): Likewise.(fold_builtin_strrchr): Likewise.(fold_builtin_strpbrk): Likewise.(expand_builtin_memory_chk): Likewise.(fold_builtin_memory_chk): Likewise.* fold-const.c (build_range_check): Handle pointer typesspecially.(fold_to_nonsharp_ineq_using_bound): Likewise.(fold_binary): Handle simple POINTER_PLUS_EXPR cases.(tree_expr_nonnegative_p): Handle POINTER_PLUS_EXPR.(tree_expr_nonzero_p): Likewise.(fold_indirect_ref_1): Look at POINTER_PLUS_EXPR insteadof PLUS_EXPR for the complex expression folding.* tree-ssa-loop-ivopts.c (determine_base_object): HandlePOINTER_PLUS_EXPR.(tree_to_aff_combination): Likewise.(force_expr_to_var_cost): Likewise.(force_expr_to_var_cost): Likewise. Create a POINTER_PLUS_EXPRinstead of PLUS_EXPR for pointers.* c-format.c (check_format_arg): Mention this should be handlingPOINTER_PLUS_EXPR.* tree-stdarg.c (va_list_counter_bump): Handle POINTER_PLUS_EXPRinstead of PLUS_EXPR.(check_va_list_escapes): Likewise.(check_all_va_list_escapes): Likewise.* expr.c (expand_expr_real_1): Handle POINTER_PLUS_EXPR.(string_constant): Likewise.* tree-ssa-address.c (add_to_parts): Create a POINTER_PLUS_EXPRinstead of PLUS_EXPR for pointers.(most_expensive_mult_to_index): Likewise.(addr_to_parts): Use the correct type for the index.* c-typeck.c (build_unary_op): For pointers create the incrementas a sizetype. Create a POINTER_PLUS_EXPR instead of PLUS_EXPRfor pointers.* gimplify.c (gimplify_self_mod_expr): Create aPOINTER_PLUS_EXPR instead of PLUS_EXPR for pointers.(gimplify_omp_atomic_fetch_op): Handle POINTER_PLUS_EXPR.* tree-mudflap.c (mf_xform_derefs_1): Create aPOINTER_PLUS_EXPR instead of PLUS_EXPR for pointers.* tree-ssa-forwprop.c (forward_propagate_addr_expr_1): Add anote this should be handling POINTER_PLUS_EXPR.* varasm.c (initializer_constant_valid_p): HandlePOINTER_PLUS_EXPR.* tree-ssa-loop-prefetch.c (idx_analyze_ref): HandlePOINTER_PLUS_EXPR instead of PLUS_EXPR.(issue_prefetch_ref): Create a POINTER_PLUS_EXPR insteadof PLUS_EXPR for pointers.* tree-vect-transform.c (vect_create_addr_base_for_vector_ref):Likewise.* tree-inline.c (estimate_num_insns_1): HandlePOINTER_PLUS_EXPR.* tree-object-size.c (plus_expr_object_size): HandlePOINTER_PLUS_EXPR instead of PLUS_EXPR. Removing all the extracode which is trying to figure out which side is a pointer andis the index.(check_for_plus_in_loops_1): Likewise.(check_for_plus_in_loops): Likewise.* c-common.c (pointer_int_sum): Create aPOINTER_PLUS_EXPR instead of PLUS_EXPR for pointers.* tree-ssa-structalias.c (handle_ptr_arith): Handleonly POINTER_PLUS_EXPR. Removing all the extracode which is trying to figure out which side is a pointer andis the index.* tree-cfg.c (verify_expr): Add extra checking for pointers andPLUS_EXPR and MINUS_EXPR.Also add checking to make sure the operands of POINTER_PLUS_EXPRare correct.Copyright (C) 2006, 2007 Free Software Foundation, Inc.Copying and distribution of this file, with or without modification,are permitted in any medium without royalty provided the copyrightnotice and this notice are preserved.
